-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds callout from cloud for subscription upgrade eligibility #33549
feat: Adds callout from cloud for subscription upgrade eligibility #33549
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3a49c7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33549 +/- ##
===========================================
- Coverage 75.83% 75.81% -0.03%
===========================================
Files 511 512 +1
Lines 22172 22205 +33
Branches 5397 5403 +6
===========================================
+ Hits 16814 16834 +20
- Misses 4710 4720 +10
- Partials 648 651 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/admin/subscription/SubscriptionPage.tsx
Outdated
Show resolved
Hide resolved
986f721
to
1925762
Compare
apps/meteor/app/cloud/server/functions/syncWorkspace/syncCloudData.ts
Outdated
Show resolved
Hide resolved
f416564
to
df8e534
Compare
038d4fa
to
7dc8e55
Compare
4b8f3e6
to
69aa3d5
Compare
69aa3d5
to
54e61b1
Compare
ee63049
to
029541a
Compare
a3702a0
to
d423071
Compare
6fd40dc
apps/meteor/app/cloud/server/functions/syncWorkspace/fetchWorkspaceSyncPayload.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/cloud/server/functions/syncWorkspace/syncCloudData.spec.ts
Show resolved
Hide resolved
Co-authored-by: Kevin Aleman <[email protected]>
…ithub.com:RocketChat/Rocket.Chat into chore/bump-storybok-fuselage-ui-kit-cloud-surface
Proposed changes (including videos or screenshots)
This PR aims to adapt the SubscriptionPage to be able to render the ui-kit Callout block properly, it also adds logic to fetch the callout information texts from the cloud and save it as a private setting, which will be used only internally by the application.
Issue(s)
CONN-365
Steps to test or reproduce
Further comments