-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: make channels files list stop to use query param #33564
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
5677be7
to
aa29ebc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33564 +/- ##
================================================
Coverage ? 74.79%
================================================
Files ? 467
Lines ? 20641
Branches ? 5262
================================================
Hits ? 15439
Misses ? 4590
Partials ? 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
aa29ebc
to
3e870be
Compare
This pull request addresses CORE-725 by updating the
/api/v1/channels.files
endpoint.name
andtypeGroup
) have been moved directly to the root of the query parameters.ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS
is set, but this is intended for exceptional cases only and should not be used in standard implementations.