Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: make channels files list stop to use query param #33564

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Oct 14, 2024

This pull request addresses CORE-725 by updating the /api/v1/channels.files endpoint.

  • The query parameter has been removed from the query string, and its contents (name and typeGroup) have been moved directly to the root of the query parameters.
  • For backward compatibility, the query parameter will still be supported when the environment variable ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS is set, but this is intended for exceptional cases only and should not be used in standard implementations.

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 13a169f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33564/
on branch gh-pages at 2024-10-16 17:56 UTC

@ricardogarim ricardogarim added this to the 7.0 milestone Oct 14, 2024
@ricardogarim ricardogarim force-pushed the chore/channels-files-query-param branch from 5677be7 to aa29ebc Compare October 14, 2024 16:06
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@41ca328). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33564   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim force-pushed the chore/channels-files-query-param branch from aa29ebc to 3e870be Compare October 15, 2024 12:14
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 16, 2024 10:31
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners October 16, 2024 10:31
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit 286e1e0 into release-7.0.0 Oct 16, 2024
40 of 41 checks passed
@ggazzo ggazzo deleted the chore/channels-files-query-param branch October 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants