Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Get livechat rooms rooms properly on chats table #33568

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 14, 2024

Proposed changes (including videos or screenshots)

It fixes an incorrect else statement that's preventing to filter the agents properly in order to get livechat rooms

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: eff733c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dougfabris dougfabris marked this pull request as ready for review October 14, 2024 17:13
@dougfabris dougfabris requested a review from a team as a code owner October 14, 2024 17:13
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 14, 2024
@dougfabris dougfabris merged commit a39f3c8 into feat/single-contact-id Oct 14, 2024
8 of 10 checks passed
@dougfabris dougfabris deleted the chore/chats-query-permission branch October 14, 2024 17:17
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33568/
on branch gh-pages at 2024-10-14 17:33 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants