Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: missing link in AppsUsageCard info #33571

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

MartinSchoeler
Copy link
Contributor

https://rocketchat.atlassian.net/browse/PASLR-32

Fixes missing link on a modal in the AppsUsageCard

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 7fcd7f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@MartinSchoeler MartinSchoeler added this to the 7.0 milestone Oct 14, 2024
@ggazzo ggazzo force-pushed the regression/missing-link branch from 483230d to d5bd47c Compare October 15, 2024 01:01
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33571/
on branch gh-pages at 2024-10-16 20:34 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@e59d783). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33571   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 15, 2024 20:43
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 15, 2024 20:43
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
@ggazzo ggazzo merged commit 80880e2 into release-7.0.0 Oct 17, 2024
51 checks passed
@ggazzo ggazzo deleted the regression/missing-link branch October 17, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants