Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Get contacts from contacts.search endpoint #33573

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: Get contacts from contacts.search endpoint #33573

merged 1 commit into from
Oct 15, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 14, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

Depends on: #33484

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c02a20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33573/
on branch gh-pages at 2024-10-15 15:10 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/search-create-edit@d90f561). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feat/search-create-edit   #33573   +/-   ##
==========================================================
  Coverage                           ?   58.43%           
==========================================================
  Files                              ?     2743           
  Lines                              ?    66158           
  Branches                           ?    14955           
==========================================================
  Hits                               ?    38662           
  Misses                             ?    24678           
  Partials                           ?     2818
Flag Coverage Δ
unit 74.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/search-contacts branch from 9adee07 to 3c02a20 Compare October 15, 2024 14:05
@dougfabris dougfabris marked this pull request as ready for review October 15, 2024 14:06
@dougfabris dougfabris requested a review from a team as a code owner October 15, 2024 14:06
@dougfabris dougfabris merged commit c0910ce into feat/search-create-edit Oct 15, 2024
45 of 50 checks passed
@dougfabris dougfabris deleted the feat/search-contacts branch October 15, 2024 17:58
dougfabris added a commit that referenced this pull request Oct 15, 2024
@dougfabris
feat: Get contacts from contacts.search endpoint (#33573)
5c221e7
dougfabris added a commit that referenced this pull request Oct 16, 2024
@dougfabris
feat: Search, create and edit contacts (#33591)
91381b3 
* feat: Get contacts from `contacts.search` endpoint (#33573)

* feat: Allows multiple emails and phones in edit contact info (#32900)

* feat: get contact data from the new endpoint

* feat: allow multiple emails and phone numbers

* chore: `ContactManagerInput` to ts

* chore: add fields validations

* chore: changeset

* chore: remove unnecessary `id` from `EditContactInfo`

* chore: skip contact center tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @tassoevan