Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: voip toggle success/error toasts being displayed in quick succession #33574

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 14, 2024

Proposed changes (including videos or screenshots)

This PR fixes a situation where you attempt to "Enable voice calling" but it fails and both the success and erros toasts are displayed in quick succession,

errors

Issue(s)

VOIP-112

Steps to test or reproduce

  • Access workspace
  • Configure and enable voip for team collab
  • Attempt to enable voice calling for the same user in two different sessions
  • Only the error message should appear

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: cdce5ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33574/
on branch gh-pages at 2024-10-16 07:32 UTC

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.42%. Comparing base (3abc1e5) to head (cdce5ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33574      +/-   ##
===========================================
- Coverage    58.43%   58.42%   -0.01%     
===========================================
  Files         2746     2746              
  Lines        66283    66285       +2     
  Branches     15001    15001              
===========================================
  Hits         38730    38730              
- Misses       24730    24732       +2     
  Partials      2823     2823              
Flag Coverage Δ
unit 74.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva added this to the 6.14 milestone Oct 15, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 15, 2024 18:12
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner October 15, 2024 18:12
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Oct 16, 2024
@kodiakhq kodiakhq bot merged commit 2b8ac8a into develop Oct 16, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the regression/registration-errors branch October 16, 2024 12:21
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants