-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: voip toggle success/error toasts being displayed in quick succession #33574
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33574 +/- ##
===========================================
- Coverage 58.43% 58.42% -0.01%
===========================================
Files 2746 2746
Lines 66283 66285 +2
Branches 15001 15001
===========================================
Hits 38730 38730
- Misses 24730 24732 +2
Partials 2823 2823
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
This PR fixes a situation where you attempt to "Enable voice calling" but it fails and both the success and erros toasts are displayed in quick succession,
Issue(s)
VOIP-112
Steps to test or reproduce
Further comments