Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: make ManagersTable component stop to use fields query param #33577

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Oct 14, 2024

This pull request addresses CORE-729 and it's parent CORE-718 by removing the query param fields sent to /v1/livechat/users/manager endpoint.

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 6f25d81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33577/
on branch gh-pages at 2024-10-15 12:32 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (e476624) to head (6f25d81).
Report is 12 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33577      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.01%     
=================================================
  Files                467      467              
  Lines              20643    20641       -2     
  Branches            5263     5262       -1     
=================================================
- Hits               15442    15439       -3     
  Misses              4590     4590              
- Partials             611      612       +1     
Flag Coverage Δ
unit 74.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim added this to the 7.0 milestone Oct 15, 2024
@ricardogarim ricardogarim force-pushed the chore/livechat-users-fields-param branch from 7f799c8 to 6f25d81 Compare October 15, 2024 12:06
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 16, 2024 09:04
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner October 16, 2024 09:04
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit e59d783 into release-7.0.0 Oct 16, 2024
53 checks passed
@ggazzo ggazzo deleted the chore/livechat-users-fields-param branch October 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants