Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] License Add-ons #33585

Closed
wants to merge 30 commits into from
Closed

[TEST] License Add-ons #33585

wants to merge 30 commits into from

Conversation

d-gubert
Copy link
Member

  • Change license types to accept any string as a module name
  • Change references to modules in the license package to accept any string
  • Include test add-on in license unit test
  • Improve license types and events for external modules
  • Move appEnableCheck to canEnableApp
  • When an external module becomes invalid, disable any apps that depend on it
  • Fix getModuleDefinition function
  • Fix code check
  • Add external module to test
  • Prevent error on startup if app can't be enabled
  • Fix external module event trigger
  • Increase coverage for PR
  • Increase MOAR
  • Add changeset
  • addon chip
  • Return external modules on getInfo
  • Fix loop definition in orchestrator
  • modals
  • fix modal link
  • Refactor LicenseModule type
  • Function to determine if the app requires add-on
  • fix lint
  • remove TODO in useAppMenu
  • Refactor type in LicenseInfo
  • fix cloud url link
  • introduce apps info callout for add-ons
  • layout adjustment
  • Add unit tests for canEnableApp
  • Add unit tests for apps license module change callback
  • Log to the server if the app is installed but can't be enabled
  • addon conference [WIP]
  • wip+
  • Send message on apps being disabled because of add-ons
  • Fix unit test of disableAppsWithAddonsCallback
  • Fix order of translation key
  • Add test case for message being sent

Proposed changes (including videos or screenshots)

This PR is meant to serve as a building point to assist in testing the full feature before merging.

PRs included:
#33433
#33534
#33483

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 686494b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33585/
on branch gh-pages at 2024-10-18 18:45 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (81998f3) to head (686494b).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #33585       +/-   ##
============================================
- Coverage    74.89%   58.57%   -16.32%     
============================================
  Files          473     2780     +2307     
  Lines        20807    66515    +45708     
  Branches      5311    15043     +9732     
============================================
+ Hits         15583    38960    +23377     
- Misses        4599    24726    +20127     
- Partials       625     2829     +2204     
Flag Coverage Δ
unit 74.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert force-pushed the test/add-ons-pre-merge branch from f1c8ad8 to 629c03f Compare October 17, 2024 23:54
@d-gubert d-gubert added the do not merge Prevent a PR from being automatically merged label Oct 18, 2024
@d-gubert d-gubert force-pushed the test/add-ons-pre-merge branch from 5e55e32 to 686494b Compare October 18, 2024 18:24
@d-gubert d-gubert closed this Oct 18, 2024
@d-gubert d-gubert deleted the test/add-ons-pre-merge branch October 18, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Prevent a PR from being automatically merged Invalid PR Title
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants