Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove allowed routes for query and fields #33622

Merged

Conversation

ricardogarim
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 544058c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33622/
on branch gh-pages at 2024-10-19 13:54 UTC

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (5f3ae1c) to head (544058c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33622   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21019    21019           
  Branches      5334     5334           
========================================
  Hits         15760    15760           
  Misses        4630     4630           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto added this to the 7.0 milestone Oct 17, 2024
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 19, 2024 14:38
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners October 19, 2024 14:38
@MarcosSpessatto MarcosSpessatto added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 19, 2024
@kodiakhq kodiakhq bot merged commit 6acbadc into develop Oct 19, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-allowed-routes-for-deprecated-query-and-fields branch October 19, 2024 15:25
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants