Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear filters button not being active after submit #33699

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 21, 2024

Proposed changes (including videos or screenshots)

Kapture 2024-10-21 at 20 23 47

Issue(s)

Steps to test or reproduce

Further comments

SCI-92
SCI-105

Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 6e3d229

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title fix: Clear filters button not being active fix: Clear filters button not being active after submit Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33699/
on branch gh-pages at 2024-10-23 15:08 UTC

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (9c76b28) to head (6e3d229).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33699   +/-   ##
=======================================================
  Coverage                   75.44%   75.44%           
=======================================================
  Files                         491      491           
  Lines                       21134    21134           
  Branches                     5338     5338           
=======================================================
  Hits                        15944    15944           
  Misses                       4555     4555           
  Partials                      635      635           
Flag Coverage Δ
unit 75.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 22, 2024 13:09
@dougfabris dougfabris requested a review from a team as a code owner October 22, 2024 13:09
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from eff9fa5 to 593ad15 Compare October 22, 2024 20:06
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the context, makes it much better.

@dougfabris
Copy link
Member Author

@gabriellsh with your help everything gets better

@dougfabris dougfabris merged commit 10d4117 into feat/single-contact-id Oct 23, 2024
51 checks passed
@dougfabris dougfabris deleted the fix/clear-button branch October 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants