Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined error message #33702

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Oct 22, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-117

@Gustrb Gustrb requested a review from a team as a code owner October 22, 2024 12:13
Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: c2e2b43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb added this to the 7.1.0 milestone Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33702/
on branch gh-pages at 2024-10-23 12:34 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.39%. Comparing base (593ad15) to head (c2e2b43).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33702   +/-   ##
=======================================================
  Coverage                   75.39%   75.39%           
=======================================================
  Files                         491      491           
  Lines                       21154    21154           
  Branches                     5344     5344           
=======================================================
  Hits                        15949    15949           
  Misses                       4568     4568           
  Partials                      637      637           
Flag Coverage Δ
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/single-contact-id branch from eff9fa5 to 593ad15 Compare October 22, 2024 20:06
@dougfabris dougfabris requested a review from a team as a code owner October 22, 2024 20:06
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a changeset?

Also, it seems the setting change on the tests is not part of this fix, right? If no, please create another PR

@Gustrb
Copy link
Contributor Author

Gustrb commented Oct 23, 2024

Hey @MarcosSpessatto since this one is going to the feature branch we are not adding changesets to specific PR's (this was suposed to be working with the changes we made, so it would make no sense).
And the extra test files were due to the outdated branch, it is now fixed :P

@Gustrb Gustrb merged commit 1e443d1 into feat/single-contact-id Oct 23, 2024
20 checks passed
@Gustrb Gustrb deleted the fix/undefined-error-message branch October 23, 2024 12:37
@KevLehman
Copy link
Contributor

I was going to mention that the ideal would be to fix where the errors are being caught so it can work with regular errors so we don't tie ourselves to meteor errors.

@Gustrb
Copy link
Contributor Author

Gustrb commented Oct 23, 2024

I guess it would be good, but I don't think it would be ideal to add such change to the scope of single contact id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants