-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: undefined error message #33702
fix: undefined error message #33702
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33702 +/- ##
=======================================================
Coverage 75.39% 75.39%
=======================================================
Files 491 491
Lines 21154 21154
Branches 5344 5344
=======================================================
Hits 15949 15949
Misses 4568 4568
Partials 637 637
Flags with carried forward coverage won't be shown. Click here to find out more. |
eff9fa5
to
593ad15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a changeset?
Also, it seems the setting change on the tests is not part of this fix, right? If no, please create another PR
Hey @MarcosSpessatto since this one is going to the feature branch we are not adding changesets to specific PR's (this was suposed to be working with the changes we made, so it would make no sense). |
I was going to mention that the ideal would be to fix where the errors are being caught so it can work with regular errors so we don't tie ourselves to meteor errors. |
I guess it would be good, but I don't think it would be ideal to add such change to the scope of single contact id |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-117