Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: add tracing instrumentation on LocalBroker #33750

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Oct 24, 2024

Adds OPTL instrumentation on LocalBroker as per OPI-48.

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: bbd5446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33750/
on branch gh-pages at 2024-10-24 17:22 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (ce283bf) to head (bbd5446).
Report is 15 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33750      +/-   ##
=================================================
- Coverage          74.97%   74.96%   -0.02%     
=================================================
  Files                480      481       +1     
  Lines              21019    21044      +25     
  Branches            5334     5339       +5     
=================================================
+ Hits               15760    15776      +16     
- Misses              4630     4636       +6     
- Partials             629      632       +3     
Flag Coverage Δ
unit 74.96% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review October 24, 2024 16:35
sampaiodiego
sampaiodiego previously approved these changes Oct 24, 2024
@ricardogarim ricardogarim changed the base branch from develop to release-7.0.0 October 24, 2024 17:06
@ricardogarim ricardogarim dismissed sampaiodiego’s stale review October 24, 2024 17:06

The base branch was changed.

@ricardogarim ricardogarim requested review from a team as code owners October 24, 2024 17:06
@ricardogarim ricardogarim changed the title chore: add tracing instrumentation on LocalBroker regression: add tracing instrumentation on LocalBroker Oct 24, 2024
@ricardogarim ricardogarim force-pushed the chore/tracing-improvements branch from ae9478d to bbd5446 Compare October 24, 2024 17:07
@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Oct 24, 2024
@ricardogarim ricardogarim added this to the 7.0 milestone Oct 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 24, 2024
@kodiakhq kodiakhq bot merged commit 349e646 into release-7.0.0 Oct 24, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/tracing-improvements branch October 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants