Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Restrict livechat visitors to their source type scope #33760

Closed
wants to merge 23 commits into from

Conversation

pierre-lehnen-rc
Copy link
Contributor

Restoring PR #33569 which got reverted on 7.0;

Proposed changes (including videos or screenshots)

  • Added source field to ILivechatVisitor type, which stores the channel (eg API, widget, SMS, email-inbox, app) that's been used by the visitor to send messages. Each visitor can now only be linked to a single source, and each user that has already been linked to a source can't be reused in another channel.
  • This change is required for the SCI project, but is otherwise unrelated as it works independently.
  • This is a breaking change because apps will no longer have access to visitors not created by them.

Issue(s)

Steps to test or reproduce

Further comments

SCI-88

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: bff9207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/apps Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 24, 2024 15:02
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 24, 2024 15:02
Copy link
Contributor

github-actions bot commented Oct 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33760/
on branch gh-pages at 2024-10-24 17:33 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (ccaa315) to head (bff9207).
Report is 49 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33760   +/-   ##
========================================
  Coverage    74.96%   74.96%           
========================================
  Files          481      481           
  Lines        21042    21042           
  Branches      5339     5339           
========================================
  Hits         15775    15775           
  Misses        4635     4635           
  Partials       632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc force-pushed the feat/channel-name-visitors-2 branch from 8ad37b9 to a5696b2 Compare October 24, 2024 17:15
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner October 24, 2024 17:15
@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from develop to release-7.0.0 October 24, 2024 17:15
Comment on lines +2 to +5
"@rocket.chat/meteor": minor
"@rocket.chat/apps": minor
"@rocket.chat/core-typings": minor
"@rocket.chat/model-typings": minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@rocket.chat/meteor": minor
"@rocket.chat/apps": minor
"@rocket.chat/core-typings": minor
"@rocket.chat/model-typings": minor
"@rocket.chat/meteor": major
"@rocket.chat/apps": major
"@rocket.chat/core-typings": minor
"@rocket.chat/model-typings": minor

Some changes should be tagged as major now, shouldn't they? Not sure about core and model typings

@matheusbsilva137 matheusbsilva137 removed the request for review from a team October 24, 2024 17:25
@casalsgh casalsgh modified the milestone: 7.0 Oct 24, 2024
@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from release-7.0.0 to develop October 28, 2024 16:29
@pierre-lehnen-rc
Copy link
Contributor Author

Closing in favor of https://adr.rocket.chat/0114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants