-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Restrict livechat visitors to their source type scope #33760
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bff9207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33760 +/- ##
========================================
Coverage 74.96% 74.96%
========================================
Files 481 481
Lines 21042 21042
Branches 5339 5339
========================================
Hits 15775 15775
Misses 4635 4635
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. |
8ad37b9
to
a5696b2
Compare
"@rocket.chat/meteor": minor | ||
"@rocket.chat/apps": minor | ||
"@rocket.chat/core-typings": minor | ||
"@rocket.chat/model-typings": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@rocket.chat/meteor": minor | |
"@rocket.chat/apps": minor | |
"@rocket.chat/core-typings": minor | |
"@rocket.chat/model-typings": minor | |
"@rocket.chat/meteor": major | |
"@rocket.chat/apps": major | |
"@rocket.chat/core-typings": minor | |
"@rocket.chat/model-typings": minor |
Some changes should be tagged as major now, shouldn't they? Not sure about core and model typings
Closing in favor of https://adr.rocket.chat/0114 |
Restoring PR #33569 which got reverted on 7.0;
Proposed changes (including videos or screenshots)
source
field toILivechatVisitor
type, which stores the channel (eg API, widget, SMS, email-inbox, app) that's been used by the visitor to send messages. Each visitor can now only be linked to a single source, and each user that has already been linked to a source can't be reused in another channel.Issue(s)
Steps to test or reproduce
Further comments
SCI-88