Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove meteor.startup from jump-to-star-message #34024

Merged
merged 5 commits into from
Nov 29, 2024
Merged

chore: remove meteor.startup from jump-to-star-message #34024

merged 5 commits into from
Nov 29, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Nov 21, 2024 •
edited by jira bot
Loading

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 21, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b63f32f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (remove-meteor-startup/jumpToPinMessage@0685bfe). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##             remove-meteor-startup/jumpToPinMessage   #34024   +/-   ##
=========================================================================
  Coverage                                          ?   75.79%           
=========================================================================
  Files                                             ?      510           
  Lines                                             ?    22063           
  Branches                                          ?     5385           
=========================================================================
  Hits                                              ?    16723           
  Misses                                            ?     4694           
  Partials                                          ?      646
Flag Coverage Δ
unit 75.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34024/
on branch gh-pages at 2024-11-29 18:54 UTC

@MartinSchoeler MartinSchoeler marked this pull request as ready for review November 27, 2024 12:29
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner November 27, 2024 12:29
@MartinSchoeler MartinSchoeler added this to the 7.2.0 milestone Nov 28, 2024
tassoevan
tassoevan requested changes Nov 29, 2024
View reviewed changes
apps/meteor/client/components/message/toolbar/useJumpToStarMessage.tsx
import { MessageAction } from '../../../../app/ui-utils/client/lib/MessageAction';
import { setMessageJumpQueryStringParameter } from '../../../lib/utils/setMessageJumpQueryStringParameter';

export const useJumpToStarMessage = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the -Action suffix to avoid confusion.

@MartinSchoeler MartinSchoeler changed the base branch from develop to remove-meteor-startup/jumpToPinMessage November 29, 2024 18:40
@MartinSchoeler MartinSchoeler merged commit 44b8ade into remove-meteor-startup/jumpToPinMessage Nov 29, 2024
8 of 9 checks passed
@MartinSchoeler MartinSchoeler deleted the remove-meteor-startup/jumpToStarMessage branch November 29, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinSchoeler @tassoevan