Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videoconf ringer fails to accept calls after a logout/login #34075

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Nov 28, 2024

Backport of #34068

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner November 28, 2024 13:25
@dionisio-bot dionisio-bot bot added this to the 7.0 milestone Nov 28, 2024
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: acc75f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Nov 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.68%. Comparing base (dfc7e0e) to head (acc75f0).
Report is 6 commits behind head on release-7.0.1.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.1   #34075   +/-   ##
==============================================
  Coverage          58.68%   58.68%           
==============================================
  Files               2789     2789           
  Lines              66847    66847           
  Branches           15026    15026           
==============================================
  Hits               39230    39230           
  Misses             24795    24795           
  Partials            2822     2822           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34075/
on branch gh-pages at 2024-11-28 13:41 UTC

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Dec 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 10, 2024
@kodiakhq kodiakhq bot merged commit 7bfa020 into release-7.0.1 Dec 10, 2024
55 of 56 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.0.1-34068 branch December 10, 2024 12:44
sampaiodiego pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants