Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine formatting toolbar tooltips for clarity #34088

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Nov 28, 2024

Proposed changes (including videos or screenshots)

This PR refines formatting toolbar tooltips by updating i18n keys and values for better clarity.

Introduced a new key with updated content and replaced the old key across files.
Removed the previous key from all language files to ensure consistency.
Lingohub generates PRs for translations of new keys automatically.
Screenshot 2024-11-29 at 3 14 26 AM
Screenshot 2024-11-29 at 3 15 08 AM
Screenshot 2024-11-29 at 3 15 18 AM

Issue(s)

Steps to test or reproduce

Further comments

CORE-841

@abhinavkrin abhinavkrin requested review from a team as code owners November 28, 2024 21:47
Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: b4ca252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (be2ede4) to head (b4ca252).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34088   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22208    22208           
  Branches      5404     5404           
========================================
  Hits         16837    16837           
  Misses        4720     4720           
  Partials       651      651           
Flag Coverage Δ
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34088/
on branch gh-pages at 2024-12-18 18:11 UTC

@MarcosSpessatto MarcosSpessatto added this to the 7.2.0 milestone Nov 29, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 2, 2024
KevLehman
KevLehman previously approved these changes Dec 13, 2024
Signed-off-by: Abhinav Kumar <[email protected]>
@kodiakhq kodiakhq bot merged commit afbc3b4 into develop Dec 18, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/improve-formatting-tools-tooltip-text branch December 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants