-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong dates on last x
date on omnichannel reports
#34113
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fe21aea The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34113 +/- ##
===========================================
+ Coverage 75.75% 75.81% +0.05%
===========================================
Files 510 512 +2
Lines 22078 22221 +143
Branches 5387 5407 +20
===========================================
+ Hits 16726 16846 +120
- Misses 4706 4722 +16
- Partials 646 653 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
is there any way to test the component? even with unit tests 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to test this?
About tests, we currently mock the return of the server with an object, but the changes I've made would affect the parameters sent to the server and its return, so I don't think we can mock that, we would probably need to find a way to inject data into the db or mock the whole endpoint |
But maybe we can have some units on the component to validate that the dates will be the right ones, no? 🤔 |
150a15d
Proposed changes (including videos or screenshots)
Fixes dates being incorrect when fetching omnichannel reports, for example currently asking for last month will return the last 30 days, even if the month just started, this fixes
last week
last month
last 6 months
last year
Issue(s)
SUP-703