Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hide discussions created for Video Conference Calls #34128

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Dec 5, 2024

Proposed changes (including videos or screenshots)

This PR adds logic to hide discussions created for Video Conference Calls (Persistent Chat) by default.

Issue(s)

CORE-804

Steps to test or reproduce

  1. Install an app provider for video calls;
  2. Setup Conference Calls in the workspace's settings.
  3. Enable Persistent Chat in the Conference Calls settings.
  4. Make a call to someone and see that the discussions will be created hidden (in the sidebar) by default.

Further comments

@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Dec 5, 2024
Copy link
Contributor

dionisio-bot bot commented Dec 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: c0db114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.2.0 milestone Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34128/
on branch gh-pages at 2024-12-16 18:38 UTC

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (430b6a2) to head (c0db114).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34128   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review December 5, 2024 21:54
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner December 5, 2024 21:54
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 16, 2024
@kodiakhq kodiakhq bot merged commit a4ef5ab into develop Dec 16, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/CORE-804 branch December 16, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants