Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not load unnecessary CachedCollection data for embedded layout #34138

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 6, 2024

Proposed changes (including videos or screenshots)

Embedded layouts do not have the sidedar, but a bunch of of stuff related to it is still loaded anyway. This PR aims to improve the embedded layout performance for those use cases.

Issue(s)

CORE-820

Steps to test or reproduce

Regular view:
This behavior should not have changed.
1 - Open workspace and devtools in the network tab
2 - Log in
3 - The following request should be present: https://workspace/api/v1/method.callAnon/rooms%3Aget

Embedded layout:
1 - Open workspace with ?layout=embedded search query
2 - Open devtools in the network tab
3 - Log in
4 - The following request should NOT be present: https://workspace/api/v1/method.callAnon/rooms%3Aget

Every other feature should work normally. Since this is a change to client collections, the following SHOULD NOT be impacted:

  • Settings
  • Permissions
  • Messages

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (072a749) to head (ab4eb86).
Report is 42 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34138   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22130    22130           
  Branches      5394     5394           
========================================
  Hits         16773    16773           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34138/
on branch gh-pages at 2024-12-06 17:37 UTC

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: ab4eb86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh marked this pull request as ready for review December 6, 2024 21:11
@gabriellsh gabriellsh requested a review from a team as a code owner December 6, 2024 21:11
@gabriellsh gabriellsh changed the title chore: Stop loading sidebar on embedded layout chore: Stop fetching sidebar data on embedded layout Dec 6, 2024
@gabriellsh gabriellsh changed the title chore: Stop fetching sidebar data on embedded layout chore: Do not load unnecessary CachedCollection data for embedded layout Dec 6, 2024
@MarcosSpessatto MarcosSpessatto added this to the 7.2.0 milestone Dec 13, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2024
@ggazzo ggazzo merged commit 224cc68 into develop Dec 19, 2024
55 checks passed
@ggazzo ggazzo deleted the chore/poc-embedded branch December 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants