-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not load unnecessary CachedCollection data for embedded layout #34138
Conversation
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34138 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22130 22130
Branches 5394 5394
========================================
Hits 16773 16773
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes (including videos or screenshots)
Embedded layouts do not have the sidedar, but a bunch of of stuff related to it is still loaded anyway. This PR aims to improve the embedded layout performance for those use cases.
Issue(s)
CORE-820
Steps to test or reproduce
Regular view:
This behavior should not have changed.
1 - Open workspace and devtools in the network tab
2 - Log in
3 - The following request should be present: https://workspace/api/v1/method.callAnon/rooms%3Aget
Embedded layout:
1 - Open workspace with
?layout=embedded
search query2 - Open devtools in the network tab
3 - Log in
4 - The following request should NOT be present: https://workspace/api/v1/method.callAnon/rooms%3Aget
Every other feature should work normally. Since this is a change to client collections, the following SHOULD NOT be impacted:
Further comments