fix: Messages not being processed for all slack servers

[lucas-a-pelegrino]

Proposed changes (including videos or screenshots)

This PR aims to fix an issue with the onMessage() function that exited before processing messages for all slack adapters, the cause was that while inside the loop, after processing the message on the first adapter the loop exited when accessing the any of the if statements present in the function.

By replacing the return statements for continue, the loop now continues iterating through the slack adapters as expected.

Issue(s)

SUP-700

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a333cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34148/
on branch gh-pages at 2024-12-17 20:20 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (0fcdc3e) to head (0a333cc).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #34148   +/-   ##
========================================
  Coverage    75.83%   75.83%           
========================================
  Files          511      511           
  Lines        22172    22172           
  Branches      5397     5397           
========================================
  Hits         16814    16814           
  Misses        4710     4710           
  Partials       648      648           

Flag	Coverage Δ
unit	75.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[matheusbsilva137]

Can you please add a changeset and describe what's being fixed in the PR title (instead of how)?

[KevLehman]

is there any way to add, at least, units? 😬

if not, can you create a task for adding them later? (and to convert the file to TS, cause we have an eslint rule for ensuring we don't return inside of loops lol)

[matheusbsilva137]

I believe we should also fix onMessageDelete and addChannel methods
They also iterate on slackAdapters and are currently using return instead of continue

[lucas-a-pelegrino]

is there any way to add, at least, units? 😬

if not, can you create a task for adding them later? (and to convert the file to TS, cause we have an eslint rule for ensuring we don't return inside of loops lol)

I agree, we should create tasks for migrating this service to TS.

[KevLehman]

pls create the tasks we mentioned to improve the logic on these adapters 🙏🏽