fix: race condition in livechat popout mode cross origin #34158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: eb4dc8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34158 +/- ##
========================================
Coverage 75.81% 75.81%
========================================
Files 512 512
Lines 22208 22208
Branches 5404 5404
========================================
Hits 16837 16837
Misses 4720 4720
Partials 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Dec 16, 2024
MarcosSpessatto
requested changes
Dec 17, 2024
MarcosSpessatto
approved these changes
Dec 17, 2024
dougfabris
approved these changes
Dec 18, 2024
jeanfbrito
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We had an issue that caused the livechat popout mode to not work when in cross domains, this fix was developed #33944 but it had a race condition issue, trying to use window.postMessage() right after window.open() does not guarantee that the message will be received, and assuring that the page has loaded in cross domains can be very finicky, so I changed the approach to use the
checkPoppedOutWindowcallback to properly register the guest to the popover using something similar to thesetGuestTokenlivechat api callIssue(s)
SUP-708
Steps to test or reproduce
A good way to test this issue is to disable the registration form, that can cause the popover to have different tokens