-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avatar disabling when it is set to Default #34160
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
apps/meteor/client/views/account/profile/AccountProfileForm.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/avatar/UserAvatarEditor/UserAvatarEditor.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/avatar/UserAvatarEditor/UserAvatarEditor.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/avatar/UserAvatarEditor/UserAvatarEditor.tsx
Outdated
Show resolved
Hide resolved
@thepiyush-303 I looked at it deeper and indeed my recommendation didn't work. |
The changes you provided seem valid at first glance, but they are not functioning as expected. When the form is submitted, the Screencast.from.2024-12-13.11-04-45.webmWorking on it! |
This PR introduces a new prop,
profileAvatar
, in theUserAvatarEditor
component. TheprofileAvatar
prop is passed from theAccountProfileForm
component and indicates whether the value isundefined
or a validAvatarObject
. This distinction determines whether the "Default Avatar" option should be disabled or enabled.Proposed changes (including videos or screenshots)
Issue(s)
Closes #34159
Steps to test or reproduce
Further comments