-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: featuresPreview
wrong DB structure
#34209
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: efb13eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34209 +/- ##
========================================
Coverage 75.81% 75.81%
========================================
Files 512 512
Lines 22205 22208 +3
Branches 5403 5404 +1
========================================
+ Hits 16834 16837 +3
Misses 4720 4720
Partials 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
AccountFeaturePreviewPage.tsx
was sending the whole feature on save payload - it should be onlyname
andvalue
This fix is needed to allow changing the rules of
enableQuery
that is currently depending on the value of a feature that is going to be official (Enhanced navigation)Issue(s)
Steps to test or reproduce
Further comments