-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validation on bot field used by js.sdk #34214
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34214 +/- ##
========================================
Coverage 75.81% 75.81%
========================================
Files 512 512
Lines 22205 22205
Branches 5403 5403
========================================
Hits 16834 16834
Misses 4720 4720
Partials 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Proposed changes (including videos or screenshots)
Change the validation of the
bot
field to make it compatible with our js.SDK: https://github.com/RocketChat/Rocket.Chat.js.SDK/blob/master/src/lib/message.ts#L17Issue(s)
Steps to test or reproduce
Further comments