Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation on bot field used by js.sdk #34214

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Change the validation of the bot field to make it compatible with our js.SDK: https://github.com/RocketChat/Rocket.Chat.js.SDK/blob/master/src/lib/message.ts#L17

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 5da93f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (9521463) to head (5da93f9).
Report is 27 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34214   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22205    22205           
  Branches      5403     5403           
========================================
  Hits         16834    16834           
  Misses        4720     4720           
  Partials       651      651           
Flag Coverage Δ
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34214/
on branch gh-pages at 2024-12-18 15:33 UTC

@sampaiodiego sampaiodiego marked this pull request as ready for review December 18, 2024 18:53
@sampaiodiego sampaiodiego requested review from a team as code owners December 18, 2024 18:53
@sampaiodiego sampaiodiego modified the milestones: 7.1.1, 7.2.0 Dec 19, 2024
@sampaiodiego sampaiodiego merged commit 347819b into develop Dec 20, 2024
49 checks passed
@sampaiodiego sampaiodiego deleted the fix-sendmessage-for-js-sdk branch December 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants