Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Meteor.call for addAllUserToRoom method (server) #34486

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MarcosSpessatto
Copy link
Member

https://rocketchat.atlassian.net/browse/CORE-901

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto added this to the 7.3.0 milestone Dec 23, 2024
Copy link
Contributor

dionisio-bot bot commented Dec 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 40d625e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (c84543f) to head (40d625e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34486      +/-   ##
===========================================
- Coverage    59.28%   59.28%   -0.01%     
===========================================
  Files         2820     2820              
  Lines        67932    67917      -15     
  Branches     15102    15099       -3     
===========================================
- Hits         40275    40264      -11     
+ Misses       24831    24829       -2     
+ Partials      2826     2824       -2     
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34486/
on branch gh-pages at 2024-12-23 11:05 UTC

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review January 17, 2025 11:45
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner January 17, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants