refactor: Move add and remove role code out of Roles model

[sampaiodiego]

Proposed changes (including videos or screenshots)

Moved business logic out of the Roles model to proper functions. This will also remove the dependency of notifyListener from the Roles model.

Issue(s)

Extracted from #34154
ARCH-1356

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (b62b0a6) to head (a61018f).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #34488      +/-   ##
===========================================
- Coverage    59.28%   59.28%   -0.01%     
===========================================
  Files         2820     2820              
  Lines        67931    67903      -28     
  Branches     15102    15094       -8     
===========================================
- Hits         40274    40254      -20     
+ Misses       24831    24827       -4     
+ Partials      2826     2822       -4     

Flag	Coverage Δ
unit	75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34488/
on branch gh-pages at 2024-12-23 20:02 UTC

[changeset-bot]

⚠️ No Changeset found

Latest commit: a61018f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR