fix: videoconf ringer not working after a temporary disconnection #35330
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e60575a The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35330 +/- ##
===========================================
- Coverage 59.46% 59.42% -0.04%
===========================================
Files 2830 2829 -1
Lines 68582 68330 -252
Branches 15178 15132 -46
===========================================
- Hits 40781 40606 -175
+ Misses 25132 25066 -66
+ Partials 2669 2658 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
approved these changes
Feb 26, 2025
|
@pierre-lehnen-rc could you add a milestone and the steps to reproduce the issue in the PR description? |
aleksandernsilva
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
|
scuciatto
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
|
/patch |
|
Pull request #35422 added to Project: "undefined" |
|
/backport 7.3.4 |
|
Pull request #35431 added to Project: "undefined" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The VideoConfManager was tracking changes to the authenticated UserId to determine if an user is logged in or not, but in some cases when the connection to the server is interrupted and a new connection is started, the UserId will be available before the new Connection's authentication is completed. In some situation that we were not yet able to reproduce in development, this caused the client to attempt to subscribe to videoconf events in an unauthenticated connection, which would fail and prevent videoconf messages from being received.
This PR changes the VideoConfManager to track the connection and authentication state along with the UserId, ensuring that the subscription is refreshed whenever any of those things change.
Issue(s)
SUP-744
Steps to test or reproduce
Further comments