Skip to content

Commit

Permalink
chore: Remove lint-staged
Browse files Browse the repository at this point in the history 
Using `lint-staged` is somewhat ineffective when linting TypeScript files due to how a module depends on its environment.
  • Loading branch information
@tassoevan
tassoevan committed Jul 31, 2024
1 parent e6dc9b5 commit d2cb97e
Show file tree
Hide file tree
Showing 27 changed files with 35 additions and 382 deletions.
1 change: 0 additions & 1 deletion .husky/pre-commit
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
. "$(dirname "$0")/_/husky.sh"

yarn update-readme
yarn lint-staged --allow-empty
7 changes: 0 additions & 7 deletions .vscode/settings.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"editor.formatOnSave": true,
"[typescript]": {
"editor.formatOnSave": false
},
"[typescriptreact]": {
"editor.formatOnSave": false
},
"editor.defaultFormatter": "esbenp.prettier-vscode",
"[pegjs]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
Expand Down
44 changes: 22 additions & 22 deletions README.md
View file

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions _templates/create-package/library/files/package.json.t
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ to: packages/<%=package%>/package.json
".:build:cjs": "tsc -p tsconfig.cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc"
},
Expand All @@ -46,7 +45,6 @@ to: packages/<%=package%>/package.json
"eslint": "~8.8.0",
"jest": "~27.5.1",
"lint-all": "workspace:~",
"lint-staged": "~12.3.3",
"prettier": "~2.5.1",
"rimraf": "~3.0.2",
"ts-jest": "~27.1.3",
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"bump": "workspace:~",
"husky": "~9.0.11",
"hygen": "~6.1.5",
"lint-staged": "~13.2.1",
"pinst": "~3.0.0",
"turbo": "~2.0.9",
"update-readme": "workspace:~",
Expand Down
2 changes: 0 additions & 2 deletions packages/css-in-js/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"build": "rollup -c",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -54,7 +53,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7",
"rollup": "~2.67.3",
"rollup-plugin-terser": "~7.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/css-supports/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"build": "tsc -p tsconfig.esm.json && tsc -p tsconfig.cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"docs": "typedoc",
"bump-next": "bump-next"
},
Expand All @@ -40,7 +39,6 @@
"bump": "workspace:~",
"eslint": "~8.38.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7",
"rimraf": "~3.0.2",
"typedoc": "~0.25.13",
Expand Down
2 changes: 0 additions & 2 deletions packages/emitter/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"build": "rollup -c",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -53,7 +52,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rollup": "~2.67.3",
Expand Down
2 changes: 0 additions & 2 deletions packages/eslint-config-alt/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"scripts": {
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"bump-next": "bump-next"
},
"peerDependencies": {
Expand All @@ -42,7 +41,6 @@
"bump": "workspace:~",
"eslint": "~8.38.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7"
},
"dependencies": {
Expand Down
2 changes: 0 additions & 2 deletions packages/fuselage-hooks/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
".:build:rollup": "rollup -c",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"bump-next": "bump-next"
},
Expand All @@ -62,7 +61,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"react": "^17.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/fuselage-polyfills/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"scripts": {
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"bump-next": "bump-next"
},
"dependencies": {
Expand All @@ -39,7 +38,6 @@
"bump": "workspace:~",
"eslint": "~8.38.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7"
}
}
2 changes: 0 additions & 2 deletions packages/fuselage-toastbar/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"storybook": "start-storybook -p 6006",
Expand All @@ -66,7 +65,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rimraf": "~3.0.2",
Expand Down
1 change: 0 additions & 1 deletion packages/fuselage-tokens/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-prettier": "~4.2.1",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"postcss-scss": "~4.0.6",
"prettier": "~2.8.7",
Expand Down
2 changes: 0 additions & 2 deletions packages/fuselage/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
".:build:dev:check": "es-check es5 dist/*.development.js",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"watch": "jest --watch",
"docs": "cross-env NODE_ENV=production build-storybook -o ../../static/fuselage",
Expand Down Expand Up @@ -109,7 +108,6 @@
"jest": "~29.5.0",
"jest-axe": "~8.0.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"mini-css-extract-plugin": "~2.7.6",
"normalize.css": "^8.0.1",
"npm-run-all": "^4.1.5",
Expand Down
2 changes: 0 additions & 2 deletions packages/icons/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"build": "build-icons",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"bump-next": "bump-next"
},
"devDependencies": {
Expand All @@ -38,7 +37,6 @@
"bump": "workspace:~",
"eslint": "~8.38.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rimraf": "^3.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/layout/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"storybook": "start-storybook -p 6006 --no-version-updates",
Expand Down Expand Up @@ -62,7 +61,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"react": "~17.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/logo/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
".:build:logo": "build-logo",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -54,7 +53,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"react": "^17.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/memo/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -48,7 +47,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7",
"rimraf": "~3.0.2",
"ts-jest": "~29.1.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/mp3-encoder/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"build": "rollup -c",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -56,7 +55,6 @@
"jest": "~29.5.0",
"jest-environment-jsdom": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7",
"rollup": "~3.20.4",
"ts-jest": "~29.1.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/onboarding-ui/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"storybook": "start-storybook -p 6006 --no-version-updates",
Expand Down Expand Up @@ -68,7 +67,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"react": "^17.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/peggy-loader/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"bump-next": "bump-next"
},
"bugs": {
Expand All @@ -51,7 +50,6 @@
"bump": "workspace:~",
"eslint": "~8.38.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"peggy": "3.0.2",
"prettier": "~2.8.7",
Expand Down
2 changes: 0 additions & 2 deletions packages/prettier-config/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"scripts": {
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"bump-next": "bump-next"
},
"peerDependencies": {
Expand All @@ -44,7 +43,6 @@
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-prettier": "~4.2.1",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"prettier": "~2.8.7"
}
}
2 changes: 0 additions & 2 deletions packages/string-helpers/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -49,7 +48,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rimraf": "^3.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/styled/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -45,7 +44,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rimraf": "^3.0.2",
Expand Down
2 changes: 0 additions & 2 deletions packages/stylis-logical-props-middleware/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
".:build:cjs": "tsc -p tsconfig-cjs.json",
"lint": "lint",
"lint-and-fix": "lint-and-fix",
"lint-staged": "lint-staged",
"test": "jest --runInBand --passWithNoTests",
"docs": "typedoc",
"bump-next": "bump-next"
Expand All @@ -45,7 +44,6 @@
"eslint": "~8.38.0",
"jest": "~29.5.0",
"lint-all": "workspace:~",
"lint-staged": "~13.2.1",
"npm-run-all": "^4.1.5",
"prettier": "~2.8.7",
"rimraf": "^3.0.2",
Expand Down
3 changes: 0 additions & 3 deletions turbo.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
"build-storybook": {
"dependsOn": ["^build"],
"outputs": ["storybook-static/**"]
},
"lint-staged": {
"outputs": []
}
}
}
Loading

0 comments on commit d2cb97e

Please sign in to comment.