fix(fuselage): Unable to remove items on PaginatedMultiSelect

RocketChat · Sep 5, 2023 · fde3bcf · fde3bcf
1 parent 775de59
commit fde3bcf
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/packages/fuselage/src/components/PaginatedSelect/PaginatedMultiSelect.tsx b/packages/fuselage/src/components/PaginatedSelect/PaginatedMultiSelect.tsx
@@ -73,18 +73,22 @@ export const PaginatedMultiSelect = ({
     currentValue.some((opt) => opt.value === option.value)
   );
 
-  const internalChanged = (option: PaginatedMultiSelectOption) => {
-    if (currentValue.some((opt) => opt.value === option.value)) {
-      const newValue = currentValue.filter((opt) => opt.value !== option.value);
+  const internalChanged = useMutableCallback(
+    (option: PaginatedMultiSelectOption) => {
+      if (currentValue.some((opt) => opt.value === option.value)) {
+        const newValue = currentValue.filter(
+          (opt) => opt.value !== option.value
+        );
 
+        setInternalValue(newValue);
+        return onChange(newValue);
+      }
+
+      const newValue = [...currentValue, option];
       setInternalValue(newValue);
       return onChange(newValue);
     }
-
-    const newValue = [...currentValue, option];
-    setInternalValue(newValue);
-    return onChange(newValue);
-  };
+  );
 
   const [visible, hide, show] = useVisible();