fix(fuselage): AudioPlayer: Infinity duration audio files crashing
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
added a commit
that referenced
this pull request
Sep 13, 2023
#1159) Co-authored-by: Douglas Fabris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments
The issue is that some kind of audio files are not returning the correct duration with metaData, they are returning
Infinitywhich is crashing the UI.So this is a common issue and we have a few workarounds for solving this -
Fetch the entire file in background and then get the duration. Didn't use this approach as it would unnecessarily download(fetch) the entire file.
Seek the audio element to play some audio by setting the
currentTimeof the element, set thiscurrentTimeto some very big number, which will cause it to fetch the real duration of the audio file and then we can use this duration. I've used this approach, but I ran into another issue when using this approach. After setting thecurrentTimeto a very big number, the audio element was breaking for no apparent reason. It was not seeking the audio current time to any desired location, so had to create a new Audio element and use this new element to fetch the duration.