Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): AutoComplete a11y best practices improvement #1168

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • fix AutoComplete rest props type with AllHTMLAttributes and spread props into input
    this is important so that the input receives the necessary attributes to be accessible (eg. id, aria-label,...)
  • improve AutoComplete stories
  • improve AutoComplete tests, including a11y violations

Issue(s)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: 1ed5c55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title fix(fuselage): AutoComplete a11y fix(fuselage): AutoComplete a11y best practices improvement Sep 14, 2023
@dougfabris dougfabris marked this pull request as ready for review September 15, 2023 19:02
@dougfabris dougfabris merged commit 0ce7918 into main Sep 15, 2023
4 checks passed
@dougfabris dougfabris deleted the fix/autoComplete branch September 15, 2023 21:15
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants