Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): withTitle prop not working on MultiSelect and PaginatedMultiSelect #1201

Closed
wants to merge 2 commits into from

Conversation

aleksandernsilva
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 2c93085

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: withTitle prop not working on MultiSelect and PaginatedMultiSelect fix(fuselage): withTitle prop not working on MultiSelect and PaginatedMultiSelect Oct 19, 2023
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 19, 2023 17:21
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition doesn't seem valuable to me, you can achieve this using the renderItem prop.
The title doesn't make sense, since we do not have withTitle prop there's no way to be working
Also, I would not recommend adding a tooltip to the SelectOption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants