-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(message-parser): Added ChannelMention in the markup #1215
Conversation
Signed-off-by: brf153 <[email protected]>
🦋 Changeset detectedLatest commit: 441beb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@brf153 thanks for the contribution. Seems CLA was not signed. Can you double-check if you agree and if you do, sign it? |
@casalsgh is it signed now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please adjust the title following conventional commits rules
I did not get it. What is the conventional commit rule and which particular aspect of the commit message does the term 'title' refer to? |
@ggazzo Has everything been completed? Are there any remaining modifications to be made? |
Thanks for the PR @brf153 😁👏 |
fix(markup-problem):
Added ChannelMention in the type Markup
Proposed changes (including videos or screenshots)
Initially, the bold, strike, and italic markup was not working on the mobile while mentioning the channel name in the message box.
I have made the necessary changes in the React Native repo but there is a specific change that is required in the fuselage repo as well for that change to work. We need to add ChannelMention in the type Markup for this change to work. I have made these changes and raising the PR for the same.
After adding the changes, we would be able to see the Channel in the message box.
Issue(s)
RocketChat/Rocket.Chat.ReactNative#5305