Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): Added ChannelMention in the markup #1215

Merged
merged 3 commits into from
Nov 8, 2023
Merged

fix(message-parser): Added ChannelMention in the markup #1215

merged 3 commits into from
Nov 8, 2023

Conversation

brf153
Copy link
Contributor

@brf153 brf153 commented Nov 6, 2023

fix(markup-problem):

Added ChannelMention in the type Markup

Proposed changes (including videos or screenshots)

Initially, the bold, strike, and italic markup was not working on the mobile while mentioning the channel name in the message box.
Screenshot from 2023-11-06 16-53-18

I have made the necessary changes in the React Native repo but there is a specific change that is required in the fuselage repo as well for that change to work. We need to add ChannelMention in the type Markup for this change to work. I have made these changes and raising the PR for the same.

After adding the changes, we would be able to see the Channel in the message box.
WhatsApp Image 2023-11-06 at 17 04 13

Issue(s)

RocketChat/Rocket.Chat.ReactNative#5305

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: 441beb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/message-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@casalsgh casalsgh requested a review from hugocostadev November 6, 2023 20:00
hugocostadev
hugocostadev previously approved these changes Nov 7, 2023
@casalsgh
Copy link
Contributor

casalsgh commented Nov 7, 2023

@brf153 thanks for the contribution. Seems CLA was not signed. Can you double-check if you agree and if you do, sign it?

@brf153
Copy link
Contributor Author

brf153 commented Nov 7, 2023

@casalsgh is it signed now?

ggazzo
ggazzo previously requested changes Nov 7, 2023
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the title following conventional commits rules

@brf153
Copy link
Contributor Author

brf153 commented Nov 7, 2023

@ggazzo

Please adjust the title following conventional commit rules

I did not get it. What is the conventional commit rule and which particular aspect of the commit message does the term 'title' refer to?

@ggazzo ggazzo changed the title Added ChannelMention in the markup inside message-parser fix(message-parser): Added ChannelMention in the markup Nov 7, 2023
@brf153
Copy link
Contributor Author

brf153 commented Nov 8, 2023

@ggazzo Has everything been completed? Are there any remaining modifications to be made?

@ggazzo ggazzo dismissed their stale review November 8, 2023 12:38

solved

@hugocostadev hugocostadev merged commit 684b73c into RocketChat:main Nov 8, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
@casalsgh
Copy link
Contributor

casalsgh commented Nov 8, 2023

Thanks for the PR @brf153 😁👏
About the conventional commit rules, please check this link: https://www.conventionalcommits.org/en/v1.0.0/#:~:text=The%20Conventional%20Commits%20specification%20is,automated%20tools%20on%20top%20of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants