fix(message-parser): Italics for channel and user mentions #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Italics rule doesn't work for some cases like
_italics@test_
and_italics#test_
because as soon as it checks@
or#
symbol, it tries to match it with user and channel mentions, and the last underscore is matched underUTF8NamesValidation
which doesn't makes sense as first part of user and channel mentions rule doesn't parse mentions, so shouldn't useUTF8NamesValidation
.Issue(s)
Further comments
SUP-343