Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): Italics for channel and user mentions #1219

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Nov 9, 2023

Proposed changes (including videos or screenshots)

Italics rule doesn't work for some cases like _italics@test_ and _italics#test_ because as soon as it checks @ or # symbol, it tries to match it with user and channel mentions, and the last underscore is matched under UTF8NamesValidation which doesn't makes sense as first part of user and channel mentions rule doesn't parse mentions, so shouldn't use UTF8NamesValidation.

Issue(s)

Further comments

SUP-343

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 62ac927

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@scuciatto scuciatto requested a review from gabriellsh November 10, 2023 11:53
@tassoevan tassoevan merged commit c09ef5b into main Nov 13, 2023
6 checks passed
@tassoevan tassoevan deleted the fix/italics-mentions branch November 13, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants