Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): Handle onBlur prop on AutoComplete #1222

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Nov 16, 2023

Proposed changes (including videos or screenshots)

Sometimes we need to send the onBlur event as prop to the AutoComplete component which overrides the already implemented onBlur event which is used to hide the suggestions box, due to which the suggestions are not hiding after moving away from the component.

Issue(s)

Further comments

TC-1030

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 1e82e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal force-pushed the fix/autoComplete-blur-action branch from 64d8114 to 1998749 Compare November 16, 2023 15:42
@yash-rajpal yash-rajpal changed the title chore(fuselage): Introduce onBlurAction prop for AutoComplete Component chore(fuselage): Don't let over-write onBlur event Nov 16, 2023
@yash-rajpal yash-rajpal changed the title chore(fuselage): Don't let over-write onBlur event chore(fuselage): Handle `onBlur Nov 16, 2023
@yash-rajpal yash-rajpal changed the title chore(fuselage): Handle `onBlur chore(fuselage): Handle onBlur prop on AutoComplete Nov 16, 2023
tassoevan
tassoevan previously approved these changes Nov 16, 2023
@tassoevan tassoevan changed the title chore(fuselage): Handle onBlur prop on AutoComplete fix(fuselage): Handle onBlur prop on AutoComplete Nov 16, 2023
@tassoevan tassoevan merged commit ab9e4bf into main Nov 16, 2023
6 checks passed
@tassoevan tassoevan deleted the fix/autoComplete-blur-action branch November 16, 2023 18:07
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants