Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage-toastbar): Pause ToastBar timer while hovering #1406

Merged
merged 14 commits into from
Jul 18, 2024
Merged

feat(fuselage-toastbar): Pause ToastBar timer while hovering #1406

merged 14 commits into from
Jul 18, 2024

Conversation

debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2bc9b1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@rocket.chat/fuselage-toastbar Minor
@rocket.chat/fuselage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RocketChat RocketChat deleted a comment from CLAassistant Jun 24, 2024
dougfabris
dougfabris requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Would be better to pause the interval while the user is hovering
  • Since it changes the end user experience, it shouldn't be a chore

@debdutdeb debdutdeb force-pushed the dont-close-toast-when-hovering branch from abb2d8e to 4329652 Compare June 25, 2024 06:43
@debdutdeb debdutdeb requested a review from dougfabris June 25, 2024 06:45
@debdutdeb debdutdeb changed the title chore: don't close toast when hovering feat: don't close toast when hovering Jun 25, 2024
@dougfabris dougfabris changed the title feat: don't close toast when hovering feat(fuselage-toastbar): Pause ToastBar timer when hovering Jul 9, 2024
dougfabris
dougfabris previously approved these changes Jul 9, 2024
View reviewed changes
@dougfabris dougfabris changed the title feat(fuselage-toastbar): Pause ToastBar timer when hovering feat(fuselage-toastbar): Pause ToastBar timer while hovering Jul 9, 2024
dougfabris
dougfabris previously approved these changes Jul 9, 2024
View reviewed changes
dougfabris
dougfabris previously approved these changes Jul 9, 2024
View reviewed changes
@dougfabris dougfabris force-pushed the dont-close-toast-when-hovering branch from da52ca4 to 25628b5 Compare July 18, 2024 14:38
@dougfabris dougfabris force-pushed the dont-close-toast-when-hovering branch from 25628b5 to 85fd8d4 Compare July 18, 2024 14:43
@dougfabris dougfabris requested a review from tassoevan July 18, 2024 14:44
@tassoevan tassoevan merged commit 781f4aa into main Jul 18, 2024
6 checks passed
@tassoevan tassoevan deleted the dont-close-toast-when-hovering branch July 18, 2024 17:03
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@dougfabris dougfabris dougfabris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debdutdeb @CLAassistant @tassoevan @dougfabris