Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use j2se variable and collapse on split #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use j2se variable and collapse on split #34

wants to merge 1 commit into from

Commits on Aug 17, 2022

  1. use j2se variable and collapse on split 

    The getJVMArgs() function has two problems:
 - It uses the J2SE pointer directly, rather than its abstraction,
   leading to null pointer accesses.
 - It splits on " " without collapsing consecutive occurances of the
   token, leading to invalid arguments being passed to the JVM (e.g. the
   main class is passed in as an empty string) when the xml has
   whitespace in the java-vm-args attribute.

Fix these two problems by using the proper variable for accessing the
JavaVMArgs, and split them in a fashion that skips consecutive
whitespace.

In a similar vein, also strip whitespace in the args prior to doing this
work so that an entirely empty attribute does not lead to us
unnecessarily adding arguments.
    @klarose
    klarose committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1ae887f View commit details
    Browse the repository at this point in the history