Sourcery refactored main branch #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/main
branch
from
fefb839 to
2be0efb
Compare
| attributes = { | ||
| return { |
There was a problem hiding this comment.
Function HomeLINKProperty.extra_state_attributes refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-239
to
+258
| self._parent_key in coordinator.data[COORD_PROPERTIES] | ||
| and self._key | ||
| in coordinator.data[COORD_PROPERTIES][self._parent_key][COORD_DEVICES] | ||
| self._parent_key not in coordinator.data[COORD_PROPERTIES] | ||
| or self._key | ||
| not in coordinator.data[COORD_PROPERTIES][self._parent_key][ | ||
| COORD_DEVICES | ||
| ] | ||
| ): | ||
| for reading in coordinator.data[COORD_PROPERTIES][self._parent_key][ | ||
| COORD_READINGS | ||
| ]: | ||
| if reading.type != self._readingtype: | ||
| return | ||
| for reading in coordinator.data[COORD_PROPERTIES][self._parent_key][ | ||
| COORD_READINGS | ||
| ]: | ||
| if reading.type != self._readingtype: | ||
| continue | ||
| for device in reading.devices: | ||
| if device.serialnumber != self._key: | ||
| continue | ||
| for device in reading.devices: | ||
| if device.serialnumber != self._key: | ||
| continue | ||
| self._state = device.values[len(device.values) - 1].value | ||
| self._readingdate = device.values[ | ||
| len(device.values) - 1 | ||
| ].readingdate | ||
| break | ||
| self._state = device.values[len(device.values) - 1].value | ||
| self._readingdate = device.values[ | ||
| len(device.values) - 1 | ||
| ].readingdate | ||
| break |
There was a problem hiding this comment.
Function HomeLINKReadingSensor._initial_attributes refactored with the following changes:
- Add guard clause (
last-if-guard)
Comment on lines
-260
to
+263
| attributes = read_state(self.hass, self.device_class, self._key) | ||
| if attributes: | ||
| if attributes := read_state(self.hass, self.device_class, self._key): |
There was a problem hiding this comment.
Function HomeLINKReadingSensor.async_added_to_hass refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-35
to
-36
| if not device_id: | ||
| pass |
There was a problem hiding this comment.
Function build_device_identifiers refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!