Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude whole project dir when listing in case where project i… #573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Szpadel
Copy link

@Szpadel Szpadel commented Jan 26, 2025

…s places inside excluded dir (like /tmp or ~/tmp)

While doing some testing reasoning I noticed that model gets confused by information that working directory is empty, yet file inside is open. I found that this was caused by putting my test project in /tmp.
Current logic tries to exclude “noise” files inside project, but the glob used does not take into consideration working directory. In case project was inside excluded directory name it would always exclude everything.
This simple PR fix that by appending working dir to exclusion glob to limit it to names inside project directory.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Create new project inside one of excluded directories like /tmp and confirm api request Current Working Directory Files section to contain correct listing.

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Fixes exclusion pattern in listFiles() to prevent entire project directories from being excluded when located inside ignored directories.

  • Bug Fix:
    • Fixes issue in listFiles() in list-files.ts where projects inside excluded directories (e.g., /tmp) were entirely excluded.
    • Updates exclusion pattern to be relative to dirPath, ensuring only specific subdirectories are ignored.

This description was created by Ellipsis for 048863e. It will automatically update as commits are pushed.

…s places inside excluded dir (like /tmp or ~/tmp)
Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 048863e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant