Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow fix #786

Closed
wants to merge 5 commits into from

Conversation

amazon1148
Copy link

@amazon1148 amazon1148 commented Feb 5, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Adds a GitHub Actions workflow for VS Code extension release and updates package.json scripts and type declarations.

  • Workflow:
    • Adds release.yml to automate VS Code extension release on main branch push or manual trigger.
    • Includes steps for Node.js setup, dependency installation, packaging, and uploading to Azure Blob Storage.
  • Scripts:
    • Adds package:vsce script in package.json for VS Code extension packaging.
    • Updates vscode:prepublish script to use package:vsce.
  • Type Declarations:
    • Adds index.d.ts for doctrine and react modules in src/@types/.

This description was created by Ellipsis for fd7419c. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: fd7419c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amazon1148 amazon1148 closed this Feb 5, 2025
@@ -0,0 +1 @@
{"root":["./src/app.tsx","./src/index.tsx","./src/setuptests.ts","./src/vite-env.d.ts","./src/__mocks__/vscrui.ts","./src/__mocks__/@vscode/webview-ui-toolkit/react.ts","./src/components/chat/announcement.tsx","./src/components/chat/autoapprovemenu.tsx","./src/components/chat/browsersessionrow.tsx","./src/components/chat/chatrow.tsx","./src/components/chat/chattextarea.tsx","./src/components/chat/chatview.tsx","./src/components/chat/contextmenu.tsx","./src/components/chat/reasoningblock.tsx","./src/components/chat/taskheader.tsx","./src/components/chat/__tests__/chattextarea.test.tsx","./src/components/chat/__tests__/chatview.auto-approve.test.tsx","./src/components/chat/__tests__/chatview.test.tsx","./src/components/common/careticon.tsx","./src/components/common/codeaccordian.tsx","./src/components/common/codeblock.tsx","./src/components/common/demo.tsx","./src/components/common/markdownblock.tsx","./src/components/common/thumbnails.tsx","./src/components/common/vscodebuttonlink.tsx","./src/components/common/__mocks__/codeblock.tsx","./src/components/common/__mocks__/markdownblock.tsx","./src/components/history/historypreview.tsx","./src/components/history/historyview.tsx","./src/components/history/__tests__/historyview.test.tsx","./src/components/mcp/mcpenabledtoggle.tsx","./src/components/mcp/mcpresourcerow.tsx","./src/components/mcp/mcptoolrow.tsx","./src/components/mcp/mcpview.tsx","./src/components/mcp/__tests__/mcptoolrow.test.tsx","./src/components/prompts/promptsview.tsx","./src/components/prompts/__tests__/promptsview.test.tsx","./src/components/settings/apiconfigmanager.tsx","./src/components/settings/apioptions.tsx","./src/components/settings/experimentalfeature.tsx","./src/components/settings/glamamodelpicker.tsx","./src/components/settings/openaimodelpicker.tsx","./src/components/settings/openroutermodelpicker.tsx","./src/components/settings/settingsview.tsx","./src/components/settings/tabnavbar.tsx","./src/components/settings/__tests__/apiconfigmanager.test.tsx","./src/components/settings/__tests__/settingsview.test.tsx","./src/components/ui/button.tsx","./src/components/ui/dropdown-menu.tsx","./src/components/ui/index.ts","./src/components/welcome/welcomeview.tsx","./src/context/extensionstatecontext.tsx","./src/context/__tests__/extensionstatecontext.test.tsx","./src/lib/utils.ts","./src/services/gitservice.ts","./src/stories/button.stories.ts","./src/stories/dropdownmenu.stories.tsx","./src/stories/vscrui/dropdown.stories.tsx","./src/utils/command-validation.ts","./src/utils/context-mentions.ts","./src/utils/format.ts","./src/utils/getlanguagefrompath.ts","./src/utils/highlight.ts","./src/utils/mcp.ts","./src/utils/textmatetohljs.ts","./src/utils/validate.ts","./src/utils/vscode.ts","./src/utils/__tests__/command-validation.test.ts","./src/utils/__tests__/context-mentions.test.ts","../src/shared/extensionmessage.ts","../src/shared/historyitem.ts","../src/shared/webviewmessage.ts","../src/shared/api.ts","../src/shared/array.ts","../src/shared/checkexistapiconfig.ts","../src/shared/combineapirequests.ts","../src/shared/combinecommandsequences.ts","../src/shared/context-mentions.ts","../src/shared/experiments.ts","../src/shared/getapimetrics.ts","../src/shared/mcp.ts","../src/shared/modes.ts","../src/shared/support-prompt.ts","../src/shared/tool-groups.ts","../src/shared/vscodeselectorutils.ts","../src/shared/__tests__/checkexistapiconfig.test.ts","../src/shared/__tests__/modes.test.ts","../src/shared/__tests__/support-prompts.test.ts","../src/shared/__tests__/vscodeselectorutils.test.ts"],"errors":true,"version":"5.7.2"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsbuildinfo file is an auto-generated cache and should typically be added to .gitignore. Committing it can lead to unnecessary conflicts. Please remove it from version control per our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d58180f7b224d6db54dab6b5

@@ -0,0 +1,4 @@
declare module "doctrine" {
const doctrine: any
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'any' for the 'doctrine' module reduces type safety. If possible, consider providing more specific type definitions or using an existing type declaration package.

@@ -0,0 +1,9 @@
declare module "react" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaring custom modules for 'react' and 'react/jsx-runtime' with an 'any' type can undermine TypeScript’s benefits and conflict with official type definitions. Prefer using the official '@types/react' package unless there’s a compelling reason otherwise.

@amazon1148 amazon1148 deleted the release-workflow-fix branch February 5, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant