Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - ECDEV-1379 - Profile Card requests (Add & Update) #1

Closed
wants to merge 10 commits into from

Conversation

tszulc
Copy link
Member

@tszulc tszulc commented Jan 7, 2020

What's this PR do?

  • nested the CreditCard data under the card key
  • moved validation of credit card only if there's card data set
  • added token key with value, if there's token data set
  • added comment key with value
  • updates the Create and Update PaymentProfileCardRequest tests

Should follow Bambora V1.0.5

ECDEV-1379

How should this be manually tested?

  1. On roomroster.v2 replace lemonstand/omnipay-beanstream with roomroster/omnipay-beanstream
  2. Test that all Payment Profile and Payment Profile Card requests still work
  3. Run ./vendor/bin/phpunit (add --verbose if you want more details)

Checklist

  • All breaking changes have been tested across mobile and web projects. Ex: schema changes
  • Has been stress tested. Ex: CSV upload can handle 5 rows or 500
  • Any commands that change schema / data will be ran on every server (Production, staging, sales) at the same time.

@tszulc tszulc added the bug Something isn't working label Jan 7, 2020
@tszulc tszulc requested a review from tinavandervecht January 7, 2020 18:34
@tszulc tszulc changed the title Bugfix - Profile Card requests (Add & Update) Bugfix - ECDEV-1379 - Profile Card requests (Add & Update) Jan 7, 2020
Copy link

@tinavandervecht tinavandervecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you frickin did it

@tszulc
Copy link
Member Author

tszulc commented Jan 7, 2020

as per my discussion with @tinavandervecht:
We are keeping this PR open even though it's been approved so that the branch is not accidentally deleted, and so that once lemonstand#12 goes in we can switch lemonstand/omnipay-beanstream to point back to dev-master (from dev-bugfix-profile-card-requests) in our repo

@tszulc
Copy link
Member Author

tszulc commented Jan 8, 2020

I've made the executive decision, that I'll just close this PR instead of keeping it open even after it's been approved

@tszulc tszulc closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants