Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Executor
role for the Treasury contractWhy
The Treasury contract should have two distinct roles:
Default Admin
andExecutor
, instead of just the Default Admin role as it was before. The Default Admin role is assigned to the deployer, whose function is to manage the assignment of other roles. Ideally, only the deployer should have this role.The Executor role is assigned to the Timelock contract, which will execute Governor proposals, and only it will be able to call the withdraw functions. The Admin should not have the ability to withdraw funds, as that is not part of its function.
The Treasury contract is now deployed after the other contracts within the same module, as it is necessary to call the
grantRole
function post-deployment to assign the Executor role to the Timelock.