-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment / upgrade script for StRIF version 2 #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to create a new file here for this? By doing that it erases the history from one version to another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you've created new test file?
The PR separates Version 1 and Version 2 StRIF contracts and tests. In the previous PR Alex wrote new functionality on top of the version 1. I restored the old version because we need both in order to upgrade old to new. Now the Repo has 2 versions of the contract and tests for both of them. And the upgrade script |
I have united tests for versions 1 and 2 into one file = deleted one extra test file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We may merge that in
Ignition script which deploys StRIF second version and upgrades the contract