add example vars into dyndnstask,add dyndns to test.yml, modified han…

…dler and add fake handler

tasks/dyndns.yml

@@ -1,15 +1,51 @@
 ---
-
-- name: DynDNS - remove DynDNS
-  delegate_to: localhost
-  community.general.xml:
-    path: "{{ local_config_path }}"
-    xpath: /opnsense/OPNsense/DynDNS{{ item }}
-    state: absent
-    pretty_print: true
-  notify: register dyndns
-  with_items: "{{ opn_dyndns_accounts_remove }}"
-  when: opn_dyndns_accouts_remove is defined
+#
+#opn_dyndns_general:
+#  - key: enabled
+#    value: "1"
+#  - key: verbose
+#    value: "0"
+#  - key: allowipv6nano 
+#    value: "0"
+#  - key: daemon_delay
+#    value: "300"
+#  - key: backend
+#    value: "opnsense"
+#opn_dyndns_accounts:
+#  - uuid: "8e4627c4-21ff-4252-a331-3d1adee0a023"
+#    settings:
+#      - key: enabled
+#        value: "1"
+#      - key: service
+#        value: "testservice"
+#      - key: protocol
+#        value: ""
+#      - key: server
+#        value: ""
+#      - key: username
+#        value: "user"
+#      - key: password
+#        value: "pass"
+#      - key: resourceId
+#        value: ""
+#      - key: hostnames
+#        value: "all.ddnskey.com"
+#      - key: wildcard
+#        value: "0"
+#      - key: zone
+#        value: ""
+#      - key: checkip
+#        value: "web_noip-ipv4"
+#      - key: checkip_timeout
+#        value: "10"
+#      - key: force_ssl
+#        value: "1"
+#      - key: ttl
+#        value: "300"
+#      - key: interface
+#        value: "wan"
+#      - key: description
+#        value: "dyndns-description" 
 
 - name: DynDNS -  Update general DynDNS settings
   delegate_to: localhost
@@ -19,7 +55,7 @@
     value: "{{ item.value }}"
     state: present
     pretty_print: true
-  notify: register dyndns
+  notify: restart dyndns
   loop: "{{ opn_dyndns_general }}"
   when:
     - opn_dyndns_general is defined
@@ -32,7 +68,7 @@
     value: "{{ item.1.value }}"
     state: present
     pretty_print: true
-  notify: register dyndns
+  notify: restart dyndns
   with_subelements:
     - "{{ opn_dyndns_accounts }}"
     - settings

test/dyndns-test-expect.xml

@@ -0,0 +1,3 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<opnsense>
+</opnsense>

test/dyndns-test.yml

@@ -0,0 +1,49 @@
+---
+test_name: simple filter test
+
+opn_dyndns_general:
+  - key: enabled
+    value: "1"
+  - key: verbose
+    value: "0"
+  - key: allowipv6nano 
+    value: "0"
+  - key: daemon_delay
+    value: "300"
+  - key: backend
+    value: "opnsense"
+opn_dyndns_accounts:
+  - uuid: "8e4627c4-21ff-4252-a331-3d1adee0a023"
+    settings:
+      - key: enabled
+        value: "1"
+      - key: service
+        value: "noip"
+      - key: protocol
+        value: ""
+      - key: server
+        value: ""
+      - key: username
+        value: ""
+      - key: password
+        value: "user"
+      - key: resourceId
+        value: "pass"
+      - key: hostnames
+        value: "all.ddnskey.com"
+      - key: wildcard
+        value: "0"
+      - key: zone
+        value: ""
+      - key: checkip
+        value: "web_noip-ipv4"
+      - key: checkip_timeout
+        value: "10"
+      - key: force_ssl
+        value: "1"
+      - key: ttl
+        value: "300"
+      - key: interface
+        value: "wan"
+      - key: description
+        value: "dyndns-description" 

test/test.yml

@@ -48,6 +48,7 @@
         - ipsec
         - dnsserver
         - openvpn
+        - dyndns
       when:
         - test | default(_testtask) == _testtask
     - ansible.builtin.meta: flush_handlers