Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to clean unconfigured P2s #67

Merged

Conversation

Jonybat
Copy link

@Jonybat Jonybat commented May 13, 2024

#21

The expected result is that after the P2 configuration loop loop IPSec ike phase2 for ikeid {{ ikeid }}, it will search for all P2s present in config file for the respective ikeid, and then remove the ones that are not present in the host variables, based on uniqid

We have already used these 2 tasks in our prod env successfully. Unfortunately, i dont have the time atm to look into building tests for this.

@zerwes
Copy link
Collaborator

zerwes commented May 13, 2024

Hello @Jonybat
Thank you for your PR
We where aware of the issue #21 but had no time on our side to take care of this ... So I think I can implement the tests on our side.

@zerwes zerwes self-assigned this May 13, 2024
@zerwes zerwes added the enhancement New feature or request label May 13, 2024
tasks/ipsecphase1.yml Outdated Show resolved Hide resolved
zerwes added a commit that referenced this pull request May 29, 2024
zerwes added a commit that referenced this pull request May 29, 2024
@zerwes zerwes merged commit f2f44ef into Rosa-Luxemburgstiftung-Berlin:main May 29, 2024
2 checks passed
@zerwes
Copy link
Collaborator

zerwes commented May 29, 2024

Hello @Jonybat
I have implemented the test in #72
After merging your PR they succeed (as expected)
Thank you for your PR

@zerwes zerwes mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for merge PR ready for merge test required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants