Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saving of the beautification diff to the test server. #204

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

roccomoretti
Copy link
Member

From a comment by @JackMaguire in #197, we should be able to save the full diff of the beautification test output, and present it on the benchmark server in the Test files: file-tree-view 」「 file-list-view 」 entries.

@roccomoretti roccomoretti added the ready_for_review This PR is ready to be reviewed and merged. label Oct 14, 2024
@roccomoretti
Copy link
Member Author

Seems like this is working https://b3.graylab.jhu.edu/test/843568/files/full_diff.patch gives the diff for main currently.

This can be downloaded and applied locally with git apply full_diff.patch (though you may need to be careful about DOS/Unix line endings).

Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, - thank you @roccomoretti !!!

@roccomoretti roccomoretti merged commit 470f09a into main Oct 22, 2024
@roccomoretti roccomoretti deleted the beauty_diff branch October 22, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_for_review This PR is ready to be reviewed and merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants