Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain video feed aspect ratio #207

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented May 18, 2024

Before After (4:3) After (16:9 video)
Screenshot_20240518-153409 Screenshot_20240518-154600 Screenshot_20240518-154611
video-feed-ratio.webm
  • Transform texture to maintain the aspect ratio of the current feed
  • Recalculate aspect ratio and update the transform matrix as soon as settings change

@Ugzuzg Ugzuzg force-pushed the video-aspect-ratio branch from 6eaa298 to 4452a62 Compare May 18, 2024 13:43
@Ugzuzg Ugzuzg force-pushed the video-aspect-ratio branch from 4452a62 to b02e7b6 Compare May 18, 2024 14:15
@Ugzuzg Ugzuzg marked this pull request as ready for review May 18, 2024 14:22
@Ugzuzg
Copy link
Contributor Author

Ugzuzg commented Jul 16, 2024

@kripper, can you please have a look?

@kripper kripper merged commit f0792d8 into RosettaDrone:master Jul 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants