fix: config storage-layout to output in json #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Checking just now |
|
Could not merge your PR as I needed to include the js release. Included in 073eec3, thanks a lot! Will update latest tag asap |
baroooo
added a commit
to mento-protocol/mento-core
that referenced
this pull request
Dec 16, 2024
### Description Storage layout check GH action is failing because of the issue described here: Rubilmax/foundry-storage-check#178 This PR updates the action to the latest release that includes a fix for this issue ### Other changes Uses official foundry toolchain and newer versions of checkout and setup-node actions ### Tested https://github.com/mento-protocol/mento-core/actions/runs/12201703113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After latest updates, forge requires a
--jsonflag to output storage layout in json format. Without this flag,forge inspect ${contract} storage-layoutreturns a formated txt that looks like this which can not be parsed as JSON:This was causing foundry-storage-check to error out with
SyntaxError: Unexpected token '╭', " ╭---------"... is not valid JSONwhen run on any contract.https://github.com/mento-protocol/mento-core/actions/runs/12198857654/job/34031496550
This PR aims to fix this issue by forcing forge inspect to return a json output using the
--jsonflag