[WIP] sundials 3 compatiblity #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found [1] and creates a WIP patch that compiles with sundials 3+. The part for "dense" is directly based on that so it's probably at least partially right. The "sparse" part is almost certainly wrong, because I wasn't sure what to put in various parameters. Somebody who understands this code better can hopefully fix that. I also don't know how to test this code. But I think this might be useful as a starting point. It seems that the solver should be initialized after the check for Jacobian (doesn't make sense to create it and then error out), so I moved that down. [1] http://sundials.2283335.n4.nabble.com/Usage-notes-lead-to-the-example-that-uses-the-non-existent-header-cvode-cvode-dense-h-td4654260.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found [1] and creates a WIP patch that compiles with sundials 3+.
The part for "dense" is directly based on that so it's probably at
least partially right. The "sparse" part is almost certainly wrong,
because I wasn't sure what to put in various parameters. Somebody who
understands this code better can hopefully fix that. I also don't know
how to test this code. But I think this might be useful as a starting
point.
It seems that the solver should be initialized after the check for
Jacobian (doesn't make sense to create it and then error out), so I
moved that down.
[1] http://sundials.2283335.n4.nabble.com/Usage-notes-lead-to-the-example-that-uses-the-non-existent-header-cvode-cvode-dense-h-td4654260.html
For #190/