-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.23.0 #1179
v4.23.0 #1179
Conversation
TheTrunk
commented
Dec 18, 2023
•
edited by Cabecinha84
Loading
edited by Cabecinha84
- Simplifies UPNP check
- Simplifies apiServer of FluxOS
- HomeUI now shows expired applications
- HomeUI now shows all marketplace deployed applications
- HomeUI - It is now possible to redeploy expired application as well as any active application
- HomeUI - Copying and import of applications specifications json (ASJ)
- Docker prune improvments
* Streamline app start The current app.js and apiserver.js are essentially duplicates. This commit removes a lot of that duplication. Also simplifies the way UPnP is loaded, and retests UPnP on every config reload. * Use isUPnP variable instead of testing for userconfig each time * Fix typing for UPnPService * Remove UPnP duplication from serviceManager * Fix UPnP check to match current implementatio If apiPort is set and it's not 16127 - it's a UPnP node If apiPort is set and it's 16127 and routerIP is set - it's UPnP if apiPort is set and it's 16127 and no routerIP set - It's normal If no apiPort is set and no RouterIP is set - it's normal * Remove unneeded term for upnp check --------- Co-authored-by: Tadeas Kmenta <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
- Coverage 51.28% 51.18% -0.10%
==========================================
Files 43 43
Lines 13916 13935 +19
==========================================
- Hits 7137 7133 -4
- Misses 6779 6802 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
@TheTrunk haven't commit rebuild HomeUI because it shows 132 files changed to commit on my laptop... Also something about the change, I don't like 100% the My Expired Apps tab because it shows up all rows... I think we should only show one row with the latest version that got expired. But some nice improvments. Cheers! |
Hi that is exactly how it should be working. It should always show the latest specifications - the app should be shown just one time with latest specifications. Is that not the case? |
you are correct, I just saw so many presearch on my end that tought it was the case but the app name is different. All good! Nice work! |